fix possible crash on user deletion

[srvx.git] / src / timeq.c

diff --git a/src/timeq.c b/src/timeq.c
index 63906b2a96b6700bf0bd05d9148c649e4b034f5d..767bc12ea4412809d35b6e98d1072a85dd59a4a3 100644 (file)
--- a/src/timeq.c
+++ b/src/timeq.c
@@ -34,25 +34,28 @@ timeq_cleanup(void)
 {
     timeq_del(0, 0, 0, TIMEQ_IGNORE_WHEN|TIMEQ_IGNORE_FUNC|TIMEQ_IGNORE_DATA);
     heap_delete(timeq);
+    timeq = NULL;
 }
 
-void
+static void
 timeq_init(void)
 {
-    timeq = heap_new(int_comparator);
+    timeq = heap_new(ulong_comparator);
     reg_exit_func(timeq_cleanup);
 }
 
-time_t
+unsigned long
 timeq_next(void)
 {
-    void *time;
-    heap_peek(timeq, &time, 0);
-    return (time_t)time;
+    void *timep;
+    if (!timeq)
+        return ~0;
+    heap_peek(timeq, &timep, 0);
+    return (unsigned long)timep;
 }
 
 void
-timeq_add(time_t when, timeq_func func, void *data)
+timeq_add(unsigned long when, timeq_func func, void *data)
 {
     struct timeq_entry *ent;
     void *w;
@@ -60,11 +63,13 @@ timeq_add(time_t when, timeq_func func, void *data)
     ent->func = func;
     ent->data = data;
     w = (void*)when;
+    if (!timeq)
+        timeq_init();
     heap_insert(timeq, w, ent);
 }
 
 struct timeq_extra {
-    time_t when;
+    unsigned long when;
     timeq_func func;
     void *data;
     int mask;
@@ -75,9 +80,9 @@ timeq_del_matching(void *key, void *data, void *extra)
 {
     struct timeq_entry *a = data;
     struct timeq_extra *b = extra;
-    if (((b->mask & TIMEQ_IGNORE_WHEN) || ((time_t)key == b->when))
-       && ((b->mask & TIMEQ_IGNORE_FUNC) || (a->func == b->func))
-       && ((b->mask & TIMEQ_IGNORE_DATA) || (a->data == b->data))) {
+    if (((b->mask & TIMEQ_IGNORE_WHEN) || ((unsigned long)key == b->when))
+        && ((b->mask & TIMEQ_IGNORE_FUNC) || (a->func == b->func))
+        && ((b->mask & TIMEQ_IGNORE_DATA) || (a->data == b->data))) {
         free(data);
         return 1;
     } else {
@@ -86,14 +91,15 @@ timeq_del_matching(void *key, void *data, void *extra)
 }
 
 void
-timeq_del(time_t when, timeq_func func, void *data, int mask)
+timeq_del(unsigned long when, timeq_func func, void *data, int mask)
 {
     struct timeq_extra extra;
     extra.when = when;
     extra.func = func;
     extra.data = data;
     extra.mask = mask;
-    heap_remove_pred(timeq, timeq_del_matching, &extra);
+    if (timeq)
+        heap_remove_pred(timeq, timeq_del_matching, &extra);
 }
 
 unsigned int
@@ -108,12 +114,12 @@ timeq_run(void)
     void *k, *d;
     struct timeq_entry *ent;
     while (heap_size(timeq) > 0) {
-       heap_peek(timeq, &k, &d);
-       if ((time_t)k > now)
+        heap_peek(timeq, &k, &d);
+        if ((unsigned long)k > now)
             break;
-       ent = d;
-       heap_pop(timeq);
-       ent->func(ent->data);
+        ent = d;
+        heap_pop(timeq);
+        ent->func(ent->data);
         free(ent);
     }
 }