Michael Poole [Sun, 28 Mar 2004 03:28:18 +0000 (03:28 +0000)]
More helpfile fixes
* Allow a helpfile to use another module's expansion function by using
the syntax ${module:variable}, so that "set language" can be kept in
nickserv.help.
* Fix typos, unclear help entries, and add some missing entries.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-35
Zoot [Thu, 25 Mar 2004 23:17:04 +0000 (23:17 +0000)]
Documentation update
* Make some further updates to INSTALL to bring it in line with srvx 1.3
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-34
Michael Poole [Thu, 25 Mar 2004 21:41:17 +0000 (21:41 +0000)]
Message and documentation cleanups
* Update version number in INSTALL and mention where we do most of
srvx's testing.
* Move the message about using the authcookie to inside of
nickserv_make_cookie(), so that when another cookie exists, only the
"cookie already pending" message is sent.
* Fix various typos, extraneous sentences, and misplaced command
listings in nickserv.help.
* Remove (unused) fakehost options from srvx.conf.example and update
ChanServ's set_shows option.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-33
Michael Poole [Wed, 24 Mar 2004 20:32:16 +0000 (20:32 +0000)]
Infinite recursion fix; mod_chanmode_parse() fixes
* Default lang->parent to lang_C rather than language_find("C"), so
that trying to create language "C" does not cause infinite recursion.
* Fail when we try to parse a mode with an unrecognized mode character
from users; ignore them coming from a server.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-32
Michael Poole [Tue, 23 Mar 2004 00:12:53 +0000 (00:12 +0000)]
i18n fixes
* Fix typos in several message strings, and clarify others.
* Typecast first argument of gethostbyaddr() to quash warnings.
* Load languages in finalization, not initialization, and do not crash
when running off the end of a localized strings.db file.
* Show the LANGUAGE option in NickServ SET response.
* Remove mention of GHOST command when !enable_ghost.
* Only initialize alloc_argc when !defined(NDEBUG)
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-31
Michael Poole [Fri, 19 Mar 2004 14:46:53 +0000 (14:46 +0000)]
Fix language initialization bug; fix email change text
* Initialize each new account's language when registering it.
* Send the first half of the email change cookie to the old address,
rather than sending the second half (which also goes to the new
address).
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-30
Michael Poole [Wed, 17 Mar 2004 04:27:17 +0000 (04:27 +0000)]
ChanServ seen fixes; other cleanups
* Remove rule to generate the unused EXTRA_MODULES preprocessor macro.
* Properly adjust ChanServ seen time when a user leaves or is kicked
from a channel.
* Read languages from disk before initializing the core services,
since they must all be available when loading accounts.
* Fix a typo in the log BNF documentation, and add =SEVLIT support for
consistency.
* Add missing "invalid" to NSMSG_INVALID_ANNOUNCE string.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-29
Entrope [Fri, 12 Mar 2004 00:27:29 +0000 (00:27 +0000)]
fix channel mode bouncing bugs
* Make mod_chanmode_dup() copy the limit and key like one might expect.
* Make ChanServ's handle_mode() copy the default modes using
mod_chanmode_dup() instead of an implicit memcpy.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-28
Entrope [Thu, 11 Mar 2004 16:44:35 +0000 (16:44 +0000)]
Fix !resync; helpfile updates; improve ?modcmd
* Make ChanServ.RESYNC op (or voice) users when GiveOps (GiveVoice,
respectively) is 0 and the user is not on the userlist.
* Remove mention of PEONINVITE from chanserv.help.
* Mention the GIVEOWNERSHIP command in HelpServ's help file; remove
mention of the removed VERSION and WRITE commands.
* Make modcmd.MODCMD accept no options, and display the (final)
settings for the command. Update the help entry for it.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-27
Entrope [Wed, 10 Mar 2004 19:04:59 +0000 (19:04 +0000)]
License update
* Revert to plain GPLv2.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-26
Entrope [Wed, 10 Mar 2004 17:03:30 +0000 (17:03 +0000)]
Further cleanups and bugfixes
* Remove "TODO: reimplement" comment in chanserv.c, since all the
functions were already reimplemented.
* Make "/msg ChanServ huggle" work again.
* Fix error messages when bad target names given to say and emote.
* If we get a MODE change affecting a user who somehow quit already,
just ignore it.
* Add debugging checks for mod_chanmode argument counts.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-25
Entrope [Mon, 8 Mar 2004 17:41:48 +0000 (17:41 +0000)]
bug fixes (from code coverage tests)
* Fix typo in CSMSG_ADDED_USER message.
* Fix memory leak in !bans when no bans are shown.
* Fix SAY, EMOTE to user targets.
* Require unsuspended channel for OPCHAN (i.e. ChanServ is in-channel).
* Fix typo in TOPICSNARF help description.
* Fix mod_chanmode argc when reopping services.
* Fix memory leak when rehashing with with an uplink bind address.
* Fix typo in OSMSG_NICK_UNRESERVED message.
* Make *OpServ.op actually op non-ops, instead of just ops.
* Fix kick message translations when shutting down a channel.
* Fix use-after-free if an oper does ?part #badchan.
* Make mod_chanmode_apply() more sensitive to invalid mode changes.
* In create_helper(), let AddChannelUser() decide whether to op the user.
* Remove "Mod" and "Game" from "set_shows" in srvx.conf.example.
* Do not print the status "." in tests when full debug mode is on.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-24
Entrope [Thu, 4 Mar 2004 04:48:35 +0000 (04:48 +0000)]
Bug fixes and cleanups
* Remove unused src/expnhelp.c file.
* Do not call mod_chanmode_announce() if we give a user neither voice
nor ops (it causes an assertion failure).
* Make switch() on mod_chanmode argument modes a little clearer.
* Add OSMSG_NICK_UNRESERVED format string.
* Translate weekly statistics report headers for HelpServ.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-23
Entrope [Wed, 3 Mar 2004 01:47:41 +0000 (01:47 +0000)]
Various bug fixes
* In ?kickbanall, mod_chanmode_alloc(1) when we only use one arg.
* In ?modcmd ... channel_access, accept "0" to mean the same as "none."
* In log.c, make a single function to free the oldest log entry for a
log_type struct.
* Add more checks for cmd==NULL in chanserv.c:eject_user().
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-22
Entrope [Tue, 2 Mar 2004 18:21:59 +0000 (18:21 +0000)]
Add MYACCESS command; fix reference count bug in MOVE
* Always LockChannel(target) when moving a registered channel.
* Move the self-access list function from ACCESS to MYACCESS, so that
ACCESS can be marked with MODCMD_REQUIRE_CHANUSER.
* Update documentation for MYACCESS vs ACCESS.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-21
Entrope [Tue, 2 Mar 2004 04:35:35 +0000 (04:35 +0000)]
Fix NickServ language crash; convert four ChanServ binary options to level options
* When you use "/msg nickserv set language" and you have no language
assigned, it would crash. Fix this.
* Convert four ChanServ binary options to level based options:
* Voice (CHANNEL_VOICE_ALL) -> Voice (lvlGiveVoice)
* UserInfo (CHANNEL_INFO_LINES) -> UserInfo (lvlUserInfo)
* PeonInvite (CHANNEL_PEON_INVITE) -> InviteMe (lvlInviteMe)
* TopicSnarf (CHANNEL_TOPIC_SNARF) -> TopicSnarf (lvlTopicSnarf)
* Document the changes in ChanServ options.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-20
Entrope [Mon, 1 Mar 2004 16:23:51 +0000 (16:23 +0000)]
giveownership fix; handle_join +ov "fix"; revert OSMSG_FLOOD_MODERATE
* Fix !giveownership by staff.
* If ChanServ gives ops to someone onjoin, do not also give them voice.
* Translate OSMSG_FLOOD_MODERATE according to the channel options
(well, hopefully in the future we will support that) rather than the
join-flooding user's options.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-19
Adam Loghry [Mon, 1 Mar 2004 09:54:10 +0000 (09:54 +0000)]
no error on inexistent commands done publicly, announcements setting display fix, two opserv chaninfo fixes, OSMSG_FLOOD_MODERATE now works when sent to channels, and hostmask lastquit searches
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-18
Entrope [Mon, 1 Mar 2004 02:44:25 +0000 (02:44 +0000)]
Minor fixes and improvements
* Fix implementation of privileged-setter note types (it ignored the
OpServ access level before).
* Show proper message when an account's announcements are disabled.
* Translate OSMSG_FLOOD_MODERATE when sending it to a channel.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-17
Entrope [Sun, 29 Feb 2004 21:58:29 +0000 (21:58 +0000)]
Fix possible crash in chanserv.c:handle_kick()
* Delay looking up translation for CSMSG_USER_PROTECTED until we know
the kicker actually exists (if a server does the KICK, kicker==NULL).
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-16
Entrope [Sun, 29 Feb 2004 14:47:51 +0000 (14:47 +0000)]
Update .arch-inventory for in-tree builds; remove --disable-lame-tricks
* Switch to using "backup" in .arch-inventory for generated sources
and objects, since that is more accurate than "precious."
* Add normal build output to .arch-inventory so normal builds do not
cause tree-lint failures (e.g. during "tla update" - bad!).
* Remove the "lame-tricks" option from configure.in since it was not
used anyway.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-15
Zoot [Sun, 29 Feb 2004 08:07:37 +0000 (08:07 +0000)]
Limit mode parameter count.
Restrict the number of mode parameters sent by the P10 protocol
backend to MAXMODEPARAMS.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-14
Entrope [Sun, 29 Feb 2004 03:40:25 +0000 (03:40 +0000)]
Privileged service fixes
* Allow runtime control of privileged services.
* Make all oper commands default to having flags +oper.
* Add a "privileged" directive for OpServ in srvx.conf.example.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-13
Entrope [Sat, 28 Feb 2004 21:33:30 +0000 (21:33 +0000)]
more bug fixes from GameSurge
* Refuse to let an owner !set setters 501.
* Report proper level range when using !trim users <duration>.
* Refuse to let anyone !set <numericoption> 502, etc.
* Refuse to let people below owner level !set <numericoption> above
their level.
* Make !d 1d6+5 work.
* Mark users as seen/present AFTER deciding whether to show their
infoline, and PRIVMSG infolines rather than NOTICE them.
* Translate "CSMSG_USER_PROTECTED" (kick protection enforcement
message).
* Enforce plain mode changes, not just ops/deops/bans etc.
* Fix documentation for ChanServ UNREGISTER command.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-12
Entrope [Sat, 28 Feb 2004 19:08:13 +0000 (19:08 +0000)]
Fix bugs found on GameSurge
* Remove unused ARCH_REVISION macro in Makefile.am
* Fix !trim <userlevel> <duration> (so it does not trim ALL users)
* Properly allow owners to set levels to 501
* Set "deopped" when we deop the person who changed modes
* Mark the first user in a channel as a chanop (fixes a spurious
HACK(4) for newly registered channels).
* Document user level ranges for the TRIM command.
* Document user-level-based SET options as being such (rather than
being multiple-choice options).
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-11
Zoot [Sat, 28 Feb 2004 18:46:03 +0000 (18:46 +0000)]
reply correctly to bad bans
Send the correct ban being bounced.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-10
Entrope [Sat, 28 Feb 2004 04:31:12 +0000 (04:31 +0000)]
put back Make rule for arch-version.h
* Reinstate the rule to create arch-version.h, which I accidentally
deleted in the last commit
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-9
Entrope [Sat, 28 Feb 2004 00:29:08 +0000 (00:29 +0000)]
runtime helpfile splicing
* Add a miniature parser to the helpfile reader, allowing
nickserv.help's subsections to be selected at runtime.
* Move nickserv.help.m4 to nickserv.help and rewrite the
selection code to use the above.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-8
Entrope [Fri, 27 Feb 2004 16:31:57 +0000 (16:31 +0000)]
fix userlist presence tracking; "version" command on all services
* Change scan_handle_presence() to scan_user_presence(), since we always
have the userData* at the caller site.
* Make handle_auth() respect user suspensions.
* In handle_part(), let scan_user_presence() update "seen" time.
* Make ChanServ adduser command take arguments in the "expected" order
("!adduser target level", not "!adduser level target")
* Add the "version" command to all built-in services
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-7
Entrope [Wed, 25 Feb 2004 04:06:30 +0000 (04:06 +0000)]
ChanServ, OpServ and main.c bug fixes
* Read new-style channel flags from the correct field, and do not make
ChanServ rejoin channels that are still suspended
* Allow service nicknames to be omitted from srvx.conf (again)
* Construct "opserv" bot earlier so that database read works correctly
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-6
Entrope [Tue, 24 Feb 2004 03:55:22 +0000 (03:55 +0000)]
fix TODO list, services without "description" fields
Remove items in the TODO list that have been done
Restore the ability to use a default description for services when a
"nick" but no "description" is present in srvx.conf
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-5
Entrope [Fri, 20 Feb 2004 19:29:46 +0000 (19:29 +0000)]
Fix zoot style [wcmop]list; tweak events access
Use proper lower bound for zoot style user-level lists.
Change default "events" access to 350.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-4
Entrope [Thu, 19 Feb 2004 22:36:42 +0000 (22:36 +0000)]
cleanups and fixes
Fix the response when trying to set an option to an invalid access level.
Put accurate headers on zoot_list !users output.
Reduce default addban/addtimedban/delban access levels to 250.
Add advertising/support plug for #srvx.
Handle (but report) IRC socket connection errors.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-3
Entrope [Wed, 18 Feb 2004 00:18:30 +0000 (00:18 +0000)]
Support topic bursts; fix topic display in CHANINFO command
When we wipe out an older channel on our end, clear its topic.
Fix the message send function used by CHANINFO.
When we get a P10 T message, check for the extra fields added in Asuka.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-2
Entrope [Tue, 17 Feb 2004 22:02:03 +0000 (22:02 +0000)]
Indenting cleanups, +sp fix, PING fix
Add explicit copyright notice to VERSION command
When receiving a PING, respond using numnick instead of readable name
Indenting fixes
Remove out-of-date references to GamesNET
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-1
Entrope [Wed, 11 Feb 2004 04:12:26 +0000 (04:12 +0000)]
Initial import (again)
Initial import of srvx-1.3 code.
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--base-0