Fix ban reader

 * src/chanserv.c: Drop invalid bans with no reason during database reads
   and require bans to have a reason set in add_channel_ban().
git-archimport-id: srvx@srvx.net--2004-srvx/srvx--devo--1.3--patch-84

diff --git a/ChangeLog b/ChangeLog
index 43fe2e303e30f5226313fd9a8a422b13ed8b9273..ec9fe13c7bc7b10103ae96b091fdc31d0e012d64 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,20 @@
 # arch-tag: automatic-ChangeLog--srvx@srvx.net--2004-srvx/srvx--devo--1.3
 #
 
+2004-11-23 04:09:30 GMT        Zoot <zoot@gamesurge.net>       patch-84
+
+    Summary:
+      Fix ban reader
+    Revision:
+      srvx--devo--1.3--patch-84
+
+     * src/chanserv.c: Drop invalid bans with no reason during database reads
+       and require bans to have a reason set in add_channel_ban().
+
+    modified files:
+     ChangeLog src/chanserv.c
+
+
 2004-11-10 01:25:53 GMT        Michael Poole <mdpoole@troilus.org>     patch-83
 
     Summary:

diff --git a/src/chanserv.c b/src/chanserv.c
index abba31fa3717cfa974ea4014edba4a7f25c531b8..c38cd5169d329d7d15c5330791d6728910bd1f3b 100644 (file)
--- a/src/chanserv.c
+++ b/src/chanserv.c
@@ -1202,7 +1202,7 @@ add_channel_ban(struct chanData *channel, const char *mask, char *owner, time_t
     safestrncpy(bd->mask, mask, sizeof(bd->mask));
     if(owner)
         safestrncpy(bd->owner, owner, sizeof(bd->owner));
-    bd->reason = reason ? strdup(reason) : NULL;
+    bd->reason = strdup(reason);
 
     if(expires)
        timeq_add(expires, expire_ban, bd);
@@ -6591,7 +6591,7 @@ ban_read_helper(const char *key, struct record_data *rd, struct chanData *chan)
     else
         expires_time = 0;
 
-    if(expires_time && (expires_time < now))
+    if(!reason || (expires_time && (expires_time < now)))
         return;
 
     bData = add_channel_ban(chan, key, owner, set_time, triggered_time, expires_time, reason);