Author: Kev <klmitch@mit.edu>

Log message:

Don't allow G-lines to have 0 lastmod--return a "need more params" message
if lastmod evaluates to 0.  This solves the bug where not passing a lastmod
resulted in an assertion failure in gline_propagate().

git-svn-id: file:///home/klmitch/undernet-ircu/undernet-ircu-svn/ircu2/branches/u2_10_12_branch@1799 c9e4aea6-c8fd-4c43-8297-357d70d61c8c

diff --git a/ChangeLog b/ChangeLog
index 7ed903a5f180dd223faf866bcc1709acca4a8762..7c19be447871c31ef6187469eca27c3a2086cfa6 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2007-04-10  Kevin L. Mitchell  <klmitch@mit.edu>
+
+       * ircd/m_gline.c (ms_gline): lastmod must be non-zero
+
 2007-04-04  Michael Poole <mdpoole@troilus.org>
 
        * ircd/s_conf.c (rehash): Restart resolver after reading the

diff --git a/ircd/m_gline.c b/ircd/m_gline.c
index 18c1855ae6c72f99dd9c7b4adcd0365b0fc46aec..1fa28dd79064d7d556bb2173ccccce4f548df94e 100644 (file)
--- a/ircd/m_gline.c
+++ b/ircd/m_gline.c
@@ -306,6 +306,9 @@ ms_gline(struct Client *cptr, struct Client *sptr, int parc, char *parv[])
     }
   }
 
+  if (!lastmod) /* must have a lastmod parameter by now */
+    return need_more_params(sptr, "GLINE");
+
   Debug((DEBUG_DEBUG, "I have a global G-line I am acting upon now; "
         "target %s, mask %s, operforce %s, action %s, expire %Tu, "
         "lastmod %Tu, lifetime %Tu, reason: %s; gline %s!  (fields "