From e09d3d1a4a449e96530f2883c242763b6a04b7b0 Mon Sep 17 00:00:00 2001 From: Perry Lorier Date: Sat, 1 Apr 2000 08:54:11 +0000 Subject: [PATCH] Author: Isomer Log message: oops! Someone forgot to put m_pong into the parse array. Wasn't me! So undernet happily ignores all pongs... What fun! git-svn-id: file:///home/klmitch/undernet-ircu/undernet-ircu-svn/ircu2/trunk@126 c9e4aea6-c8fd-4c43-8297-357d70d61c8c --- ChangeLog | 6 +++++- ircd/ircd.c | 6 +++--- ircd/parse.c | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index d58a860..f603b52 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2000-03-30 Perry Lorier + * ircd/parse.c: fixed mystifying ping bug thats been plaguing us + for so long. Remember: m_ping MUST be in the parse array. :) + 2000-03-30 Perry Lorier * ircd/ircd.c: test in check_pings was wrong. I move that we disallow cvs commit after 10pm localtime.... @@ -277,7 +281,7 @@ # # ChangeLog for ircu2.10.11 # -# $Id: ChangeLog,v 1.55 2000-04-01 08:02:33 isomer Exp $ +# $Id: ChangeLog,v 1.56 2000-04-01 08:54:11 isomer Exp $ # # Insert new changes at beginning of the change list. # diff --git a/ircd/ircd.c b/ircd/ircd.c index c471135..94f49fa 100644 --- a/ircd/ircd.c +++ b/ircd/ircd.c @@ -304,7 +304,7 @@ static time_t check_pings(void) /* Ok, the thing that will happen most frequently, is that someone will * have sent something recently. Cover this first for speed. */ - if (CurrentTime-cptr->lasttime <= max_ping) { + if (CurrentTime-cptr->lasttime < max_ping) { expire=cptr->lasttime + max_ping; if (next_checklasttime > (max_ping*2) ) { + if (CurrentTime-cptr->lasttime >= (max_ping*2) ) { /* If it was a server, then tell ops about it. */ if (IsServer(cptr) || IsConnecting(cptr) || IsHandshake(cptr)) @@ -355,7 +355,7 @@ static time_t check_pings(void) cptr->lasttime = CurrentTime - max_ping; if (IsUser(cptr)) - sendto_one(cptr, "PING :%s", me.name); + sendto_one(cptr, MSG_PING " :%s", me.name); else sendto_one(cptr, "%s " TOK_PING " :%s", NumServ(&me), me.name); } /* of if not ping sent... */ diff --git a/ircd/parse.c b/ircd/parse.c index 3654e40..18bbfb1 100644 --- a/ircd/parse.c +++ b/ircd/parse.c @@ -199,7 +199,7 @@ struct Message msgtab[] = { TOK_PONG, 0, MAXPARA, MFLG_SLOW | MFLG_UNREG, 0, /* UNREG, CLIENT, SERVER, OPER, SERVICE */ - { mr_pong, m_ignore, ms_pong, m_ignore, m_ignore } + { mr_pong, m_pong, ms_pong, m_ignore, m_ignore } }, { MSG_ERROR, -- 2.20.1