From: Michael Poole <mdpoole@troilus.org>
Date: Sun, 3 Jan 2010 20:43:17 +0000 (+0000)
Subject: Fix SF bug #2793176 by making sure check_loop_and_lh() returns non-1 when it kills... 
X-Git-Url: http://git.pk910.de/?p=ircu2.10.12-pk.git;a=commitdiff_plain;h=2a6a833ef097f5c53726ddd6b59b5643bfa18143

Fix SF bug #2793176 by making sure check_loop_and_lh() returns non-1 when it kills a server.


git-svn-id: file:///home/klmitch/undernet-ircu/undernet-ircu-svn/ircu2/branches/u2_10_12_branch@1927 c9e4aea6-c8fd-4c43-8297-357d70d61c8c
---

diff --git a/ChangeLog b/ChangeLog
index 4fa0b8b..fe178de 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-01-03  Michael Poole <mdpoole@troilus.org>
+
+	* ircd/m_server.c (check_loop_and_lh): Never return 1 when we kill
+	another server.  Update the squit message text for maxhops and hub
+	violations.
+
 2010-01-03  Michael Poole <mdpoole@troilus.org>
 
 	* ircd/Makefile.in (IRCD_SRC): Add m_xquery.c and m_xreply.c to
diff --git a/ircd/m_server.c b/ircd/m_server.c
index 51ed2c8..1e38d39 100644
--- a/ircd/m_server.c
+++ b/ircd/m_server.c
@@ -407,14 +407,14 @@ check_loop_and_lh(struct Client* cptr, struct Client *sptr, time_t *ghost, const
     if (active_lh_line == 1)
     {
       if (exit_client_msg(cptr, LHcptr, &me,
-                          "Leaf-only link %s <- %s, check L:",
+                          "Maximum hops exceeded for %s at %s",
                           cli_name(cptr), host) == CPTR_KILLED)
         return CPTR_KILLED;
     }
     else if (active_lh_line == 2)
     {
       if (exit_client_msg(cptr, LHcptr, &me,
-                          "Non-Hub link %s <- %s, check H:",
+                          "%s is not allowed to hub for %s",
                           cli_name(cptr), host) == CPTR_KILLED)
         return CPTR_KILLED;
     }
@@ -424,11 +424,8 @@ check_loop_and_lh(struct Client* cptr, struct Client *sptr, time_t *ghost, const
       if (exit_client(cptr, LHcptr, &me, "I'm a leaf, define HUB") == CPTR_KILLED)
         return CPTR_KILLED;
     }
-    /*
-     * Did we kill the incoming server off already ?
-     */
-    if (killed)
-      return 0;
+    /* We just squit somebody, and it wasn't cptr. */
+    return 0;
   }
 
   return 1;