From: Michael Poole <mdpoole@troilus.org>
Date: Fri, 27 Oct 2006 01:25:18 +0000 (+0000)
Subject: Remove ioset engine update call that could read after free().
X-Git-Tag: v1.4.0-rc1~88
X-Git-Url: http://git.pk910.de/?a=commitdiff_plain;h=021e8747a70cb2a93e0105263293469a0d537140;hp=0c337627054388dc9695ecef7e113f7df7e33967;p=srvx.git

Remove ioset engine update call that could read after free().

src/ioset.c (ioset_connect): If the connect fails immediately, do not try
    to update the fd after closing it.
git-archimport-id: srvx@srvx.net--2006/srvx--devo--1.3--patch-68
---

diff --git a/ChangeLog b/ChangeLog
index b79a549..6901ec0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,20 @@
 # arch-tag: automatic-ChangeLog--srvx@srvx.net--2006/srvx--devo--1.3
 #
 
+2006-10-27 01:25:18 GMT	Michael Poole <mdpoole@troilus.org>	patch-68
+
+    Summary:
+      Remove ioset engine update call that could read after free().
+    Revision:
+      srvx--devo--1.3--patch-68
+
+    src/ioset.c (ioset_connect): If the connect fails immediately, do not try
+        to update the fd after closing it.
+
+    modified files:
+     ChangeLog src/ioset.c
+
+
 2006-10-27 01:06:02 GMT	Michael Poole <mdpoole@troilus.org>	patch-67
 
     Summary:
diff --git a/src/ioset.c b/src/ioset.c
index 444579e..a199275 100644
--- a/src/ioset.c
+++ b/src/ioset.c
@@ -259,7 +259,6 @@ ioset_connect(struct sockaddr *local, unsigned int sa_size, const char *peer, un
         case EHOSTUNREACH:
         case ECONNREFUSED:
             ioset_close(io_fd, 1);
-            engine->update(io_fd);
             return NULL;
         }
     }