X-Git-Url: http://git.pk910.de/?a=blobdiff_plain;f=src%2Fmod-sockcheck.c;h=8091c8a10222be03514a97df8f58f53107f3e302;hb=560c19871dfb899e254f5f3e68d4d2d567f4940c;hp=08ce625e14b65a527d43943e00c7a99d8376542e;hpb=e44152b845d78f9e8ad0b2ca3957d70f4ff7e5b1;p=srvx.git diff --git a/src/mod-sockcheck.c b/src/mod-sockcheck.c index 08ce625..8091c8a 100644 --- a/src/mod-sockcheck.c +++ b/src/mod-sockcheck.c @@ -1,5 +1,5 @@ /* mod-sockcheck.c - insecure proxy checking - * Copyright 2000-2004 srvx Development Team + * Copyright 2000-2006 srvx Development Team * * This file is part of srvx. * @@ -230,8 +230,8 @@ sockcheck_free_client(struct sockcheck_client *client) log_module(PC_LOG, LOG_INFO, "Goodbye %s (%p)! I set you free!", client->addr->hostname, client); } verify(client); - if (client->fd) - ioset_close(client->fd->fd, 1); + ioset_close(client->fd, 1); + client->fd = NULL; sockcheck_list_unref(client->tests); free(client->read); free(client->resp_state); @@ -287,13 +287,9 @@ expand_var(const struct sockcheck_client *client, char var, char **p_expansion, extern struct cManagerNode cManager; const char *expansion; unsigned int exp_length; -#ifndef __SOLARIS__ - u_int32_t exp4; - u_int16_t exp2; -#else uint32_t exp4; uint16_t exp2; -#endif + /* expand variable */ switch (var) { case 'c': @@ -661,10 +657,8 @@ sockcheck_begin_test(struct sockcheck_client *client) struct io_fd *io_fd; verify(client); - if (client->fd) { - ioset_close(client->fd->fd, 1); - client->fd = NULL; - } + ioset_close(client->fd, 1); + client->fd = NULL; do { client->state = client->tests->list[client->test_index]; client->read_pos = 0; @@ -1161,7 +1155,8 @@ sockcheck_read_conf(void) } else { sockcheck_conf.local_addr_len = 0; sockcheck_conf.local_addr = NULL; - log_module(PC_LOG, LOG_ERROR, "Error: Unable to get host named `%s', not checking a specific address.", str); + if (str) + log_module(PC_LOG, LOG_ERROR, "Error: Unable to get host named `%s', not checking a specific address.", str); } } }