Fix typos in comments and strings to reduce future slumming for credit.

[ircu2.10.12-pk.git] / ircd / m_topic.c

diff --git a/ircd/m_topic.c b/ircd/m_topic.c
index a41745c0fca6941bab5ad56e7c2dac68a4a5337d..c12a5ddc141fea694c88023e353ee1759e74a895 100644 (file)
--- a/ircd/m_topic.c
+++ b/ircd/m_topic.c
@@ -85,6 +85,8 @@
 #include "client.h"
 #include "hash.h"
 #include "ircd.h"
+#include "ircd_features.h"
+#include "ircd_log.h"
 #include "ircd_reply.h"
 #include "ircd_string.h"
 #include "msg.h"
@@ -92,18 +94,34 @@
 #include "numnicks.h"
 #include "send.h"
 
-#include <assert.h>
+/* #include <assert.h> -- Now using assert in ircd_log.h */
+#include <stdlib.h> /* for atoi() */
 
 static void do_settopic(struct Client *sptr, struct Client *cptr, 
-                       struct Channel *chptr,char *topic)
+                       struct Channel *chptr, char *topic, time_t ts)
 {
+   struct Client *from;
    int newtopic;
-   /* if +n and not @'d, return an error and ignore the topic */
-   if ((chptr->mode.mode & MODE_TOPICLIMIT) != 0 && !is_chan_op(sptr, chptr)) 
+
+   if (feature_bool(FEAT_HIS_BANWHO) && IsServer(sptr))
+       from = &me;
+   else
+       from = sptr;
+   if (IsChannelService(sptr))
+   {
+       /* allow off-channel services to set the topic of any channel */
+   }
+   else if ((chptr->mode.mode & MODE_TOPICLIMIT) && !is_chan_op(sptr, chptr))
    {
+      /* if +t and not @'d, return an error and ignore the topic */
       send_reply(sptr, ERR_CHANOPRIVSNEEDED, chptr->chname);
       return;
    }
+   else if (!client_can_send_to_channel(sptr, chptr, 1))
+   {
+      send_reply(sptr, ERR_CANNOTSENDTOCHAN, chptr->chname);
+      return;
+   }
    /* Note if this is just a refresh of an old topic, and don't
     * send it to all the clients to save bandwidth.  We still send
     * it to other servers as they may have split and lost the topic.
@@ -111,14 +129,14 @@ static void do_settopic(struct Client *sptr, struct Client *cptr,
    newtopic=ircd_strncmp(chptr->topic,topic,TOPICLEN)!=0;
    /* setting a topic */
    ircd_strncpy(chptr->topic, topic, TOPICLEN);
-   ircd_strncpy(chptr->topic_nick, cli_name(sptr), NICKLEN);
-   chptr->topic_time = CurrentTime;
-   /* Fixed in 2.10.11: Don't propergate local topics */
+   ircd_strncpy(chptr->topic_nick, cli_name(from), NICKLEN);
+   chptr->topic_time = ts ? ts : TStime();
+   /* Fixed in 2.10.11: Don't propagate local topics */
    if (!IsLocalChannel(chptr->chname))
-     sendcmdto_serv_butone(sptr, CMD_TOPIC, cptr, "%H :%s", chptr,
-                          chptr->topic);
+     sendcmdto_serv_butone(sptr, CMD_TOPIC, cptr, "%H %Tu %Tu :%s", chptr,
+                          chptr->creationtime, chptr->topic_time, chptr->topic);
    if (newtopic)
-      sendcmdto_channel_butserv_butone(sptr, CMD_TOPIC, chptr, NULL,
+     sendcmdto_channel_butserv_butone(sptr, CMD_TOPIC, chptr, NULL, 0,
                                       "%H :%s", chptr, chptr->topic);
       /* if this is the same topic as before we send it to the person that
        * set it (so they knew it went through ok), but don't bother sending
@@ -175,22 +193,25 @@ int m_topic(struct Client* cptr, struct Client* sptr, int parc, char* parv[])
       }
     }
     else 
-     do_settopic(sptr,cptr,chptr,topic);
+      do_settopic(sptr,cptr,chptr,topic,0);
   }
   return 0;
 }
 
 /*
- * ms_topic - generic message handler
+ * ms_topic - server message handler
  *
  * parv[0]        = sender prefix
  * parv[1]        = channel
+ * parv[2]        = channel timestamp (optional)
+ * parv[3]        = topic timestamp (optional)
  * parv[parc - 1] = topic
  */
 int ms_topic(struct Client* cptr, struct Client* sptr, int parc, char* parv[])
 {
   struct Channel *chptr;
   char *topic = 0, *name, *p = 0;
+  time_t ts = 0;
 
   if (parc < 3)
     return need_more_params(sptr, "TOPIC");
@@ -214,7 +235,14 @@ int ms_topic(struct Client* cptr, struct Client* sptr, int parc, char* parv[])
       continue;
     }
 
-    do_settopic(sptr,cptr,chptr,topic);
+    /* If existing channel is older or has newer topic, ignore */
+    if (parc > 3 && (ts = atoi(parv[2])) && chptr->creationtime < ts)
+      continue;
+
+    if (parc > 4 && (ts = atoi(parv[3])) && chptr->topic_time > ts)
+      continue;
+
+    do_settopic(sptr,cptr,chptr,topic, ts);
   }
   return 0;
 }